Re: [PATCH/RFD] fix connection via git protocol

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 17, 2023, 18:31 UTC
Message-ID: <xmqqildumkcw.fsf@gitster.g>
In-Reply-To: <xmqq1qkio4cq.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 6 quoted lines

>>  #define STR_(s)	# s
>> -#define STR(s)	STR_(s)
>> +#define STR(s) (STR_(s) + BUILD_ASSERT_OR_ZERO(s))
>
> OOoooh.  Clever.  A pointer plus N indexes into an array, but if the
> offset is N then the pointer is left intact so the caller does not

Sorry, but s/N/0/ obviously.

Show 6 quoted lines

> see the difference.
>
>> ... But the
>> BUILD_ASSERT doesn't seem too bad to me.
>
> Indeed.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.