Re: [PATCH] completion(switch/checkout): treat --track and -t the same

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 8, 2023, 16:25 UTC
Message-ID: <xmqqil8ktywj.fsf@gitster.g>
In-Reply-To: <ZPtISYVufU0MazO_@pobox.com>

Todd Zullinger <tmz@pobox.com> writes:

Show 17 quoted lines

> Junio C Hamano wrote:
>> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
>> writes:
>>> diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
>>> index 8835e16e811..df8bc44c285 100755
>>> --- a/t/t9902-completion.sh
>>> +++ b/t/t9902-completion.sh
>>> @@ -1622,14 +1622,22 @@ test_expect_success 'git checkout - with -d, complete only references' '
>>>  '
>>>  
>>>  test_expect_success 'git switch - with --track, complete only remote branches' '
>>> -	test_completion "git switch --track " <<-\EOF
>>> +:	test_completion "git switch --track " <<-\EOF &&
>
> Is this new leading ":" intended?  It looks out of place
> (though perhaps I just don't unerstand the context well
> enough).

Good eyes.  It makes it an expensive no-op ;-)