Re: [PATCH] fix: check parameters in json-write.c

From

Junio C Hamano <gitster@pobox.com>

Date

Sep 20, 2023, 20:10 UTC

Message-ID

<xmqqil848v1s.fsf@gitster.g>

In-Reply-To

<dc45106c-d569-3438-d2ff-c3c94b6161d7@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

> I suppose it is OK for the 2 string-value cases to assume a NULL pointer
> could be written as "" in the JSON output.  Although, I kinda think a
> NULL pointer should call BUG() as we have in the various assert_*()
> routines. It really is a kind of logic error in the caller.

FWIW, that is my preference, too.

> Regardless what we decide for the <string-value> case, in the <key>
> case, the resulting JSON would not be valid. We need for the key to
> be a non-empty string.  For example { "" : 1 } is not valid JSON.
> So the key case should call BUG() and not try to hide it.

>
> So I'm leaning towards just making it a BUG() in all cases, but I'm
> open to the other mixed handling.
>
> Jeff