Re: [PATCH v3] bulk-checkin: only support blobs in index_bulk_checkin

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 27, 2023, 04:08 UTC
Message-ID: <xmqqil7wmf50.fsf@gitster.g>
In-Reply-To: <ZROHrSmmZOIE6bl9@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 5 quoted lines

> Hmm. I wonder if retaining some flexibility in the bulk-checkin
> mechanism may be worthwhile. We discussed at the Contributor's
> Summit[^1] today that the bulk-checkin system may be a good fit for
> packing any blobs/trees created by `merge-tree` or `replay` instead of
> writing them out as loose objects.

But see the last paragraph of my review comments for the earlier round upthread. This particular function implements logic that is only applicable to blob objects, and streaming trees, commits, and tags will need their own separate helper functions. And when they are written, the top-level stream_to_pack() function can be reintroduced, which will be a thin dispatcher to the four type-specific helpers.