Re: Re* [BUG] git-bisect man page description of terms command doesn't mention old/new support
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 11, 2023, 15:05 UTC
- Message-ID
- <xmqqil54vkya.fsf@gitster.g>
- In-Reply-To
- <24a42fa6-7bc4-4a3b-8bf4-a0ef85dc457a@matthieu-moy.fr>
Matthieu Moy <git@matthieu-moy.fr> writes:
Show 7 quoted lines
> Nit: just above we have the description for `bisect start` saying:
>
> --term-{new,bad}=<term> --term-{old,good}=<term>
>
> it probably makes sense to make both homogeneous (start with the same
> alternative, and make the {...,...} vs (...|...) notations
> consistent. The (...|...) notation seems the most common).Thanks for noticing; I think it has already been fixed a few months ago, but apparently what I sent predates 3f02785d (doc/git-bisect: clarify `git bisect run` syntax, 2023-10-23). So when the patch gets merged, it will fix itself ;-)
> In any case, the patch looks good to me, thanks.
Thanks.