Re: [PATCH v2 3/6] parse-options: factor out register_abbrev() and struct parsed_option

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 13, 2024, 17:48 UTC
Message-ID: <xmqqil1qc9b6.fsf@gitster.g>
In-Reply-To: <ZfDMhJ4r5g-g-B3n@google.com>

Josh Steadmon <steadmon@google.com> writes:

> I found this change to be hard to follow, although I'm not sure anything
> actually needs to be changed. Thinking aloud below, apologies for being
> verbose.

Thanks for carefully following the code. It unfortunately has to get long, but this is the kind of review that I would appreciate most if I were the author, pointing out what is easy to understand and more importantly what is harder to follow.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.