git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/am: fix memory leak in `split_mail_stgit_series`

From
Junio C Hamano <gitster@pobox.com>
Date
May 12, 2025, 14:02 UTC
Message-ID
<xmqqikm6vsf3.fsf@gitster.g>
In-Reply-To
<pull.1961.git.git.1747015647505.gitgitgadget@gmail.com>
"Lidong Yan via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 24 quoted lines
> From: Lidong Yan <502024330056@smail.nju.edu.cn>
>
> In builtin/am.c:split_mail_stgit_series, if `fopen` failed,
> `series_dir_buf` allocated by `xstrdup` will leak. Add `free` in
> `!fp` if branch will prevent the leak.
>
> diff --git a/builtin/am.c b/builtin/am.c
> index 4afb519830f..e32a3b4c973 100644
> --- a/builtin/am.c
> +++ b/builtin/am.c
> @@ -850,8 +850,10 @@ static int split_mail_stgit_series(struct am_state *state, const char **paths,
>  	series_dir = dirname(series_dir_buf);
>  
>  	fp = fopen(*paths, "r");
> -	if (!fp)
> +	if (!fp) {
> +		free(series_dir_buf);
>  		return error_errno(_("could not open '%s' for reading"), *paths);
> +	}
>  
>  	while (!strbuf_getline_lf(&sb, fp)) {
>  		if (*sb.buf == '#')
>
> base-commit: 6f84262c44a89851c3ae5a6e4c1a9d06b2068d75
Obviously correct; will queue.  Thanks.
Previous: Patrick Steinhardt
Message 3 of 3 in “builtin/am: fix memory leak in `split_mail_stgit_series`”
  1. builtin/am: fix memory leak in `split_mail_stgit_series`Lidong Yan via GitGitGadget, May 12, 2025
  2. Patrick SteinhardtMay 12, 2025
  3. Junio C HamanoMay 12, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.