git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] fetch --prune performance problem

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 2, 2025, 01:47 UTC
Message-ID
<xmqqikkbfjn8.fsf@gitster.g>
In-Reply-To
<xmqqms9nfjvz.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 25 quoted lines
> Phil Hord <phil.hord@gmail.com> writes:
>
>> This version (V3) has three changes from V2:
>>  - Removes a header declaration I forgot to move previously
>>  - Cleans up the refs_warn_dangling_symrefs API to be more sane
>>  - Drops the ref shortening that seems ill-advised in retrospect
>>
>> Phil Hord (2):
>>   refs: remove old refs_warn_dangling_symref
>>   clean up interface for refs_warn_dangling_symrefs
>
> Hmph.  On top of which commit did you base these two patches?
> The second one does not apply on top of applying 1/2 on top of
> either v2.48.1 (where I queued the last round), v2.50.0 (the obvious
> choice for a new development), or 'master'.
>
> $ git am -s <patch-2-of-2.txt
> error: patch failed: builtin/fetch.c:1384
> error: builtin/fetch.c: patch does not apply
> error: patch failed: builtin/remote.c:1521
> error: builtin/remote.c: patch does not apply
> error: patch failed: refs.c:458
> error: refs.c: patch does not apply
>
> Thanks.

Ah, nevermind. I'll discard your v3 and will take a look at your v4 instead later.

Previous: Junio C Hamano
Message 5 of 5 in “fetch --prune performance problem”
  1. 0/2 fetch --prune performance problemPhil Hord, Jul 2, 2025
  2. 1/2 refs: remove old refs_warn_dangling_symrefPhil Hord, Jul 2, 2025
  3. 2/2 clean up interface for refs_warn_dangling_symrefsPhil Hord, Jul 2, 2025
  4. Junio C HamanoJul 2, 2025
  5. Junio C HamanoJul 2, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.