git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs: Add missing space in message

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 5, 2025, 23:03 UTC
Message-ID
<xmqqikfokrq0.fsf@gitster.g>
In-Reply-To
<a8220721-3260-15cb-6960-ca8b6433d7b5@softwolves.pp.se>
Peter Krefting <peter@softwolves.pp.se> writes:
Show 5 quoted lines
> Signed-off-by: Peter Krefting <peter@softwolves.pp.se>
> ---
>  refs/files-backend.c    | 2 +-
>  refs/reftable-backend.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Good eyes. Both of these came from 465eff81 (refs: fix invalid old object IDs when migrating reflogs, 2025-08-06), which appeared in Git 2.51.1 already. Let's merge it before the upcoming release.

Thanks.
Show 26 quoted lines
> diff --git a/refs/files-backend.c b/refs/files-backend.c
> index 054cf42f4e..1adc4b5182 100644
> --- a/refs/files-backend.c
> +++ b/refs/files-backend.c
> @@ -3124,7 +3124,7 @@ static int parse_and_write_reflog(struct files_ref_store *refs,
>  		if (!(update->flags & REF_HAVE_OLD) ||
>  		    !(update->flags & REF_HAVE_NEW) ||
>  		    !(update->flags & REF_LOG_ONLY)) {
> -			strbuf_addf(err, _("trying to write reflog for '%s'"
> +			strbuf_addf(err, _("trying to write reflog for '%s' "
>  					   "with incomplete values"), update->refname);
>  			return REF_TRANSACTION_ERROR_GENERIC;
>  		}
> diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
> index d4b7928620..eeec64798f 100644
> --- a/refs/reftable-backend.c
> +++ b/refs/reftable-backend.c
> @@ -1103,7 +1103,7 @@ static enum ref_transaction_error prepare_single_update(struct reftable_ref_stor
>  		if (!(u->flags & REF_HAVE_OLD) ||
>  		    !(u->flags & REF_HAVE_NEW) ||
>  		    !(u->flags & REF_LOG_ONLY)) {
> -			strbuf_addf(err, _("trying to write reflog for '%s'"
> +			strbuf_addf(err, _("trying to write reflog for '%s' "
>  					   "with incomplete values"), u->refname);
>  			return REF_TRANSACTION_ERROR_GENERIC;
>  		}
Previous: Peter KreftingNext: Peter Krefting
Message 2 of 3 in “refs: Add missing space in message”
  1. refs: Add missing space in messagePeter Krefting, Nov 5, 2025
  2. Junio C HamanoNov 5, 2025
  3. Peter KreftingNov 6, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.