Re: [PATCH 2/5] am: teach StGit patch parser how to read from stdin

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 8, 2015, 19:57 UTC
Message-ID: <xmqqh9qi9dmh.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1433778531-18260-3-git-send-email-pyokagan@gmail.com>

Paul Tan <pyokagan@gmail.com> writes:

Show 7 quoted lines

> git-mailsplit, which splits mbox patches, will read the patch from stdin
> when the filename is "-" or there are no files listed on the
> command-line.
>
> To be consistent with this behavior, teach the StGit patch parser to
> read from stdin if the filename is "-" or no files are listed on the
> command-line.

Hmm, doesn't

	perl -ne 'processing for each line'

with or without a BEGIN {} block, read from the standard input (if no filename is given) or the given file (if given), and more importantly, doesn't it treat a lone "-" as STDIN anyway?

That is, wouldn't it make more sense to do something like:

	test $# != 0 || set -- -
        for stgit
        do
        	...
                @@PERL@@ -ne 'BEGIN { $subject = 0 }
                	...
		' "$stgit" >"$dotest/$msgnum" || clean_abort
	done

Same for patch 5/5.

Other than that, the entire series looked great from a cursory read.

Thanks.