git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pathspec: warn on empty strings as pathspec

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 23, 2016, 06:17 UTC
Message-ID
<xmqqh9ckjuon.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAAin2AQR3yP7X=NLQ=9+0QGJZMCN7=xbpZ=H7r56RvvBfLJSEg@mail.gmail.com>
Emily Xie <emilyxxie@gmail.com> writes:
> Awesome. Thanks, Junio---this is exciting!
No, thank _you_.
> As for step 2: do you have a good sense on the timing? Around how long
> should I wait to submit the patch for it?
Not so fast.  We'll wait for others to comment first.

I am queuing this change but that does not mean anything more than that I am not outright rejecting the idea.

It is possible that others may assess the cost of having to do the two-step migration differently, and the list concensus may end up being "if it hurts, don't pass an empty string", i.e. we'd better without this patch or subsequent second step. If that happens, the first step dies without hitting 'next'. I'd say we'd wait at least for a week.

Otherwise, if the change is received favourably, we'll merge it to 'next', do the same waiting for comments. Repeat the same and then merge to 'master'. After it hits the next feature release (probably at around the end of August), the change will be seen by wider general public, and at that point we may see strong opposition from them with a good argument neither of us thought of why we shouldn't do this change, in which case we might have to revise the plan and scrap the whole thing.

So, we'll wait and see.
Previous: Emily XieNext: Emily Xie
Message 4 of 5 in “pathspec: warn on empty strings as pathspec”
  1. pathspec: warn on empty strings as pathspecEmily Xie, Jun 22, 2016
  2. Junio C HamanoJun 22, 2016
  3. Emily XieJun 22, 2016
  4. Junio C HamanoJun 23, 2016
  5. Emily XieJun 24, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.