Re: "git shortlog -sn --follow -- <path>" counts all commits to entire repo

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 10, 2017, 07:36 UTC
Message-ID: <xmqqh8wbxaww.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170909065247.wob3nuxvox4f65gg@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 14 quoted lines

> On Sat, Sep 09, 2017 at 02:37:20AM +0900, Junio C Hamano wrote:
>
>> Using log-tree traversal machinery instead of just get_revision()
>> would probably mean we would slow it down quite a bit unless we are
>> careful, but at the same time, things like "git shortlog -G<string>"
>> would suddenly start working, so this is not just helping the
>> "--follow" hack.
>
> I didn't notice that, but I'm not surprised that there are more options
> that shortlog doesn't quite work with.
>
> I don't plan on working on this myself any time soon, so maybe it's a
> good #leftoverbits candidate (though it's perhaps a little more involved
> than some).

I agree that I do not mind seeing those who haven't really touched the inner core of the system to try this change, so marking this discussion with #leftoverbits may be a good idea, but I have this gut feeling that "a little more involved" might be a bit of an understatement ;-)

But still I think it is a very good suggestion to allow log-tree to filter things more so that "shortlog $args" can become a more faithful imitation of "log $args | shortlog".

Thanks.