Re: [PATCH v2] doc: Add missing "-n" (dry-run) option to reflog man page

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 22, 2017, 03:28 UTC
Message-ID: <xmqqh8tnvvom.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.LFD.2.21.1711211038410.8568@DESKTOP-1GPMCEJ>

"Robert P. J. Day" <rpjday@crashcourse.ca> writes:

Show 6 quoted lines

> While the "git reflog" man page supports both "--dry-run" and "-n" for
> a dry run, the man page mentions only the former, not the latter.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---

I have a suspicion that this was deliberately omitted in order to keep the lines in the description short and concise. Just adding 5-columns may appear not to hurt too much, but these things tend to accumulate, so...

Queued, so that I won't lose sight of it, but won't merge unless somebody else strongly feels about it.

Thanks.

Show 20 quoted lines

>
>   sorry, i accidentally chopped off the leading lines of the patch in
> the earlier post.
>
> diff --git a/Documentation/git-reflog.txt b/Documentation/git-reflog.txt
> index 44c736f1a..472a6808c 100644
> --- a/Documentation/git-reflog.txt
> +++ b/Documentation/git-reflog.txt
> @@ -20,9 +20,9 @@ depending on the subcommand:
>  'git reflog' ['show'] [log-options] [<ref>]
>  'git reflog expire' [--expire=<time>] [--expire-unreachable=<time>]
>  	[--rewrite] [--updateref] [--stale-fix]
> -	[--dry-run] [--verbose] [--all | <refs>...]
> +	[--dry-run | -n] [--verbose] [--all | <refs>...]
>  'git reflog delete' [--rewrite] [--updateref]
> -	[--dry-run] [--verbose] ref@\{specifier\}...
> +	[--dry-run | -n] [--verbose] ref@\{specifier\}...
>  'git reflog exists' <ref>
>
>  Reference logs, or "reflogs", record when the tips of branches and