git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] tests: optionally skip `git rebase -p` tests

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 1, 2018, 06:12 UTC
Message-ID
<xmqqh8h1tjg9.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<39734e4805cbd695cd69e7c1a3016de629ac9b3c.1541016115.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> The `--preserve-merges` mode of the `rebase` command is slated to be
> deprecated soon, ...

Is everybody on board on this statement? I vaguely recall that some people wanted to have something different from what rebase-merges does (e.g. wrt first-parent history), and extending perserve-merges might be one way to do so.

I do not mind at all if the way forward were to extend rebase-merges for any future features. To me, it is preferrable having to deal with just one codepath than two written in different languages.

I just want to make sure we know everybody is on board the plan that we will eventually remove preserve-merges, tell those who want to use it to switch to rebase-merges, and we will extend rebase-merges when they raise issues with it saying that they cannot do something preserve-merges would have served them well with rebase-merges.

Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Sixt
Message 5 of 7 in “tests: allow to skip git rebase -p tests”
  1. 0/3 tests: allow to skip git rebase -p testsJohannes Schindelin via GitGitGadget, Oct 31, 2018
  2. 1/3 t3404: decouple some test cases from outcomes of previous test casesJohannes Schindelin via GitGitGadget, Oct 31, 2018
  3. 2/3 t3418: decouple test cases from a previous `rebase -p` test caseJohannes Schindelin via GitGitGadget, Oct 31, 2018
  4. 3/3 tests: optionally skip `git rebase -p` testsJohannes Schindelin via GitGitGadget, Oct 31, 2018
  5. Junio C HamanoNov 1, 2018
  6. Johannes SixtNov 1, 2018
  7. Junio C HamanoNov 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.