Re: [PATCH] diff: ensure correct lifetime of external_diff_cmd

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 10, 2019, 18:27 UTC
Message-ID: <xmqqh8eg2wsc.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAPig+cQKnEWb+co_NJ0UyZbXZrvx2KsbS_ZugdyjjYZcz8tjvw@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 9 quoted lines

> However, you might also consider using xstrdup_or_null(), like this:
>
>     external_diff_cmd = xstrdup_or_null(getenv(...));
>     if (!external_diff_cmd)
>         ...as before...
>
>>         done_preparing = 1;
>>         return external_diff_cmd;
>>  }

Looks good.