Re: [PATCH 2/3] t: add t0016-oidmap.sh

From

Junio C Hamano <gitster@pobox.com>

Date

Jun 13, 2019, 22:22 UTC

Message-ID

<xmqqh88tunvt.fsf@gitster-ct.c.googlers.com>

In-Reply-To

<20190613190229.GB27217@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> > I know there are testing philosophies that go to this level of
>> > white-box testing, but I don't think we usually do in Git. A unit
>> > test of oidmap's externally visible behavior seems like the right
>> > level to me.
>> 
>> That's a good point...  but then why does 't0011-hashmap.sh' do it in
>> the first place?  As far as I understood this t0016 mainly follows
>> suit of t0011.
>
> I'd make the same argument against t0011. :)

> I think there it at least made a little more sense because we truly are
> hashing ourselves, rather than just copying out some sha1 bytes. But I
> think I'd still argue that if I updated strhash() to use a different
> hash, I should not have to be updating t0011 to change out the hashes.

True, too.