git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Unexpected or wrong ff, no-ff and ff-only behaviour

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 12, 2019, 18:33 UTC
Message-ID
<xmqqh87rp0gy.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<87blxz9xbh.fsf@osv.gnss.ru>
Sergey Organov <sorganov@gmail.com> writes:
Show 24 quoted lines
>> If we have a project like this:
>>
>>         A               topic that is slightly stale
>>        /
>>   o---F---o---o---X     mainline
>>
>> M, A', and N should end up with identical trees:
>>
>>
>>         A-----------M   topic that is slightly stale, merged into mainline
>>        /           /
>>   o---F---o---o---X---N mainline with A' merged
>>                    \ /
>>                     A'  mainline with A rebased on top as A'
>>
>> And by forcing to rebase A to A' before merging into the mainline as
>> N, compared to advancing mainline from X to M, one major difference
>> the workflow is making is to _lose_ the information that the topic
>> was cooked in the context of an older mainline and did not take what
>> happened since F until X into account....
>
> However, committing untested M still doesn't taste as the best possible
> way of handling things in general. It'd be best to actually test M or N
> before publishing.

Oh, no question about it. I am not advocating (and I do not do personally) publishing an untested tip.

But the point is, if M and N are equally well tested before publication, they may still have bugs resulting from subtle interactions between A and F..X that is not discovered during that testing. And N loses the information that would help diagnosing what went wrong, which does not happen if you published M.

About the docs easily getting misinterpreted, I think Elijah covered it pretty well.

Thanks.
Previous: Sergey OrganovNext: Sergey Organov
Message 15 of 20 in “Unexpected or wrong ff, no-ff and ff-only behaviour”
  1. usbuser@mailbox.orgJul 9, 2019
  2. Junio C HamanoJul 9, 2019
  3. Roland JägerJul 9, 2019
  4. Elijah NewrenJul 9, 2019
  5. usbuser@mailbox.orgJul 9, 2019
  6. Elijah NewrenJul 9, 2019
  7. Bryan TurnerJul 9, 2019
  8. usbuser@mailbox.orgJul 10, 2019
  9. Junio C HamanoJul 10, 2019
  10. Sergey OrganovJul 11, 2019
  11. Junio C HamanoJul 11, 2019
  12. Sergey OrganovJul 12, 2019
  13. Elijah NewrenJul 12, 2019
  14. Sergey OrganovJul 15, 2019
  15. Junio C HamanoJul 12, 2019
  16. Sergey OrganovJul 15, 2019
  17. Junio C HamanoJul 15, 2019
  18. Sergey OrganovJul 19, 2019
  19. brian m. carlsonJul 11, 2019
  20. Sergey OrganovJul 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.