git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/1] fsmonitor: skip sanity check if the index is split

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 11, 2019, 01:43 UTC
Message-ID
<xmqqh83bjig6.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<pull.458.git.1573196960.gitgitgadget@gmail.com>
"Utsav Shah via GitGitGadget" <gitgitgadget@gmail.com> writes:
> At the very least, this patch mitigates an over-eager check for split index
> users while maintaining good invariants for the standard case.

OK, it sounds more like this "it does not make any sense to compare the position in the fsmonitor bitmap (which covers the entire thing) with the position in just a split part of the index (which covers only the delta over the base index)"? If that is the case, it means that the "check" is even worse than being "over-eager"---it simply is not correct.

Thanks, will queue.
Previous: Utsav ShahNext: Junio C Hamano
Message 5 of 14 in “fsmonitor: skip sanity check if the index is split”
  1. 0/1 fsmonitor: skip sanity check if the index is splitUtsav Shah via GitGitGadget, Nov 8, 2019
  2. 1/1 fsmonitor: skip sanity check if the index is splitUtsav Shah via GitGitGadget, Nov 8, 2019
  3. SZEDER GáborNov 12, 2019
  4. Utsav ShahNov 12, 2019
  5. Junio C HamanoNov 11, 2019
  6. Junio C HamanoNov 11, 2019
  7. Kevin WillfordNov 11, 2019
  8. Utsav ShahNov 11, 2019
  9. Kevin WillfordNov 11, 2019
  10. William BakerNov 11, 2019
  11. Junio C HamanoNov 13, 2019
  12. Utsav ShahNov 14, 2019
  13. William BakerNov 14, 2019
  14. Junio C HamanoNov 15, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.