Re: [RFC][Feature] submodule: teach subcommand 'summary' to give summary for nested submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 18, 2020, 19:48 UTC
Message-ID: <xmqqh7ylfnqi.fsf@gitster.c.googlers.com>
In-Reply-To: <20200318163234.21628-1-shouryashukla.oo@gmail.com>

Shourya Shukla <shouryashukla.oo@gmail.com> writes:

Show 9 quoted lines

> I was converting the subcommand 'summary'(of command submodule)
> from shell to C and I realised that the subcommand does not have a
> '--recursive' option in it, meaning it cannot give out summaries
> of nested submodules. My opinion on this is that an option should
> maybe exist for the same.
>
> What are the community's thoughts on this? Should the
> aforementioned option be added? Is there any feasibility of this
> option in this case?

If "git submodule summary --recursive" errors out with today's code, no sane user would be using it for any useful purpose, so I would think it is OK to add such a feature.

If it makes a usable UI for large projects that you can only choose between "include no subsubmodules" (i.e. with --no-recursive) or "include all sub(sub)*modules" (i.e. with --recursive) is another matter, though.