Re: [PATCH] git-prompt: changes == to = for zsh's sake

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 21, 2020, 00:40 UTC
Message-ID: <xmqqh7u18zu1.fsf@gitster.c.googlers.com>
In-Reply-To: <20200721002309.GA178512@pug.qqx.org>

Aaron Schrab <aaron@schrab.com> writes:

Show 6 quoted lines

> An alternate fix would be to switch to using double square brackets
> instead of single square brackets for the test. Since contents of
> double brackets have their own parsing rules the `equals` option
> doesn't apply there, and so `==` is available for checking equality
> same as in bash.  IMHO, this provides saner behavior in general;
> although it's definitely not POSIX compliant.

It won't be but it does not have to be POSIX compliant anyway; after all this is prompt support for bash with support for zsh added on the side, neither is limited to strict POSIX.

I'd say that the patch posted is good as-is.

Thanks.