Re: [PATCH 2/2] pack-objects: prefetch objects to be packed

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 21, 2020, 21:27 UTC
Message-ID: <xmqqh7u07e41.fsf@gitster.c.googlers.com>
In-Reply-To: <xmqq5zag8yg5.fsf@gitster.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 9 quoted lines

>>> The optimization makes sense to me if certain
>>> conditions are met, like...
>>> 
>>>  - Most of the time there is no missing object due to promisor, even
>>>    if has_promissor_to_remote() is true;
>>
>> I think that optimizing for this condition makes sense - most pushes (I
>> would think) are pushes of objects we create locally, and thus no
>> objects are missing.

Another simple thing I missed. Why do we specifically refer to "push" here? Is this codepath in pack-objects not used or less often used by upload-pack (which is what serves "fetch")?

I just wanted to make sure that we are not optimizing for "push", trading efficiency for "fetch" off.

Thanks.