Re: [PATCH v2] midx: use buffered I/O to talk to pack-objects

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 12, 2020, 20:28 UTC
Message-ID: <xmqqh7t7623d.fsf@gitster.c.googlers.com>
In-Reply-To: <9162c1cb-36fd-3203-ec58-4bd1501938d0@web.de>

René Scharfe <l.s.r@web.de> writes:

>  		nth_midxed_object_oid(&oid, m, i);
> -		xwrite(cmd.in, oid_to_hex(&oid), the_hash_algo->hexsz);
> -		xwrite(cmd.in, "\n", 1);
> +		fprintf(cmd_in, "%s\n", oid_to_hex(&oid));

I do think it is silly to send an object name and terminating LF in two different system calls per object.

The original uses xwrite() so that it does not have to worry about having to restart interrupted system calls and such. Do we need to do that ourselves now or does the stdio layer take care of it for us?

Show 8 quoted lines

>  	}
> -	close(cmd.in);
> +	fclose(cmd_in);
>
>  	if (finish_command(&cmd)) {
>  		error(_("could not finish pack-objects"));
> --
> 2.28.0