git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] SubmittingPatches: tighten wording on "sign-off" procedure

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 28, 2020, 10:39 UTC
Message-ID
<xmqqh7o6jjt1.fsf@gitster.c.googlers.com>

The text says "if you can certify DCO then you add a Singed-off-by trailer". But it does not say anything about people who cannot certify. A natural reading may be that if you cannot certify, you do not add the trailer, but it shouldn't hurt to be overly explicit.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/SubmittingPatches | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git c/Documentation/SubmittingPatches w/Documentation/SubmittingPatches
index d12094bac5..b091730771 100644
--- c/Documentation/SubmittingPatches
+++ w/Documentation/SubmittingPatches
@@ -307,35 +307,35 @@ wrote the patch or have the right to pass it on under the same license
 as ours, by "signing off" your patch.  Without sign-off, we cannot
 accept your patches.
 
-If you can certify the below D-C-O:
+If (and only if) you can certify the below D-C-O:
 
 [[dco]]
 .Developer's Certificate of Origin 1.1
 ____
 By making a contribution to this project, I certify that:

 a. The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

 b. The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

 c. The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

 d. I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
 ____

 you add a "Signed-off-by" trailer to your commit, that looks like
 this:
Next: Felipe Contreras
Message 1 of 5 in “SubmittingPatches: tighten wording on "sign-off" procedure”
  1. SubmittingPatches: tighten wording on "sign-off" procedureJunio C Hamano, Dec 28, 2020
  2. Felipe ContrerasDec 28, 2020
  3. Junio C HamanoDec 28, 2020
  4. Derrick StoleeDec 28, 2020
  5. SubmittingPatches: tighten wording on "sign-off" procedureJunio C Hamano, Jan 7, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.