Re: [PATCH] revision: trace topo-walk statistics
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 7, 2021, 01:37 UTC
- Message-ID
- <xmqqh7nto7ck.fsf@gitster.c.googlers.com>
- In-Reply-To
- <pull.828.git.1609302714183.gitgitgadget@gmail.com>
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 12 quoted lines
> diff --git a/revision.c b/revision.c
> index 9dff845bed6..1bb590ece78 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -3308,6 +3308,26 @@ struct topo_walk_info {
> struct author_date_slab author_date;
> };
>
> +static int topo_walk_atexit_registered;
> +static unsigned int count_explore_walked;
> +static unsigned int count_indegree_walked;
> +static unsigned int count_topo_walked;The revision walk machinery is designed to be callable more than once during the lifetime of a process. These make readers wonder if they should be defined in "struct rev_info" to allow stats collected per traversal.