git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] use delete_refs when deleting tags or branches

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 15, 2021, 20:06 UTC
Message-ID
<xmqqh7nirmmk.fsf@gitster.c.googlers.com>
In-Reply-To
<CABPp-BEUPH5Yc08uDehAXNQ5-3fJ9YeW0xscVBR45hniDe+HEg@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
> Overall, I like the patch.  Peff commented on v1 that the basic idea
> (use the part of the refs API that batches operations) is the right
> thing to do.
I concur; I agree with the general direction.

Where do we reject branch deletion based on the merged-ness? When we ask to delete three branches and one is not merged yet and cannot be removed (let's say we are not "--force"ing) but the other two are OK to remove, we do want the other two branches to go. I didn't check what the patch does with respect to this point, but as long as the updated code does not make it "all or none", it would be great.

> I would say Reviewed-by, but I'd like to get Junio's comments on the
> return code and minor race.
It would have to wait a bit more.  Thanks for a review.
Previous: Elijah NewrenNext: Junio C Hamano
Message 3 of 5 in “use delete_refs when deleting tags or branches”
  1. use delete_refs when deleting tags or branchesPhil Hord, Aug 14, 2019
  2. Elijah NewrenJan 15, 2021
  3. Junio C HamanoJan 15, 2021
  4. Junio C HamanoJan 15, 2021
  5. Phil HordJan 16, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.