Re: [PATCH v2 2/2] prune: save reachable-from-recent objects with bitmaps

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 29, 2021, 01:37 UTC
Message-ID: <xmqqh7jpan0y.fsf@gitster.g>
In-Reply-To: <YImCcxVq6AWjtv8k@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> -for repack in '' true; do
> -	title=${repack:+repack}
> -	title=${title:-loose}
> -
> +for title in loose repack bitmap; do
>  	test_expect_success "make repo completely empty ($title)" '
>  		rm -rf .git &&
>  		git init

Just this part alone is worth the update ;-) It was not even clear what "repack" meant in the old loop, or what the significance of setting it to "true" (as opposed to say "false").

Of course, the early return in the code removed by this patch explains how the bug happened. Will queue; thanks.