Re: [PATCH] maintenance: disable cron on macOS

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 10, 2021, 19:47 UTC
Message-ID: <xmqqh7cjyeqb.fsf@gitster.g>
In-Reply-To: <pull.1075.git.1636569360002.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 9 quoted lines

>     This one is really tricky because we can't notice anything is wrong
>     without running git maintenance start or git maintenance stop
>     interactively on macOS. The tests pass just fine because the UI alert
>     gets automatically ignored during the test suite.
>     
>     This is a bit of a half-fix: it avoids the UI alert, but has a corner
>     case of not un-doing the cron schedule if a user manages to select it
>     (under suitable permissions such that it succeeds). For the purpose of
>     the timing of the release, I think this is an appropriate hedge.

Reverting the "git maintainance run --scheduler=<scheduler>" topic altogether to give us time to stop and think may be another obvious option, but it probably is OK to tell macOS users that they may have cron but Git won't work with their cron with this patch.

In any case, let's leave it (slightly) broken for macOS folks by applying this quickfix.

Thanks.

PS.

I was puzzled by the lack of a call to validate_scheduler() at the very beginning of resolve_scheduler(), by the way. Or even earlier during the verification of the command line options. I wonder if on macOS, --scheduler=nosuch and --scheduler=cron should behave the same way, both saying "unrecognized", instead of saying that only to the former and "not available" to the latter.