Re: [PATCH v2 0/9] sparse-checkout: make cone mode the default
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 14, 2022, 23:19 UTC
- Message-ID
- <xmqqh780jf5h.fsf@gitster.g>
- In-Reply-To
- <xmqqlexcqon9.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 22 quoted lines
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> == Updates Log == >> >> Changes since v1: >> >> * rebased on master, to remove dependence on en/present-despite-skipped >> (which has since merged to master). Earlier version of series wasn't >> picked up anyway, so rebasing should be safe. >> * Wording and code style tweaks suggested by Stolee in his review >> >> == Overview == >> >> This patch changes the default mode for sparse-checkout from non-cone mode >> to cone-mode, and marks non-cone mode as deprecated. There is no plan to >> remove non-cone mode, we are merely recommending against its use. > > Hopefully there are some convincing explanation to help users > understand why the cone mode is recommended in the documentation in > these patches. Was there a discussion on list to give our unanimous > support for this plan, or is this only preference by a developer or > two who have worked on the sparse-checkout code recently?
OK. There are a few things that I found questionable, but they were mostly documentation issues (and lack of updates to two places, one in read-tree and the other in config/core.txt).
Thanks.