git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tests: cache glibc version check

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 4, 2022, 20:20 UTC
Message-ID
<xmqqh72r4v6g.fsf@gitster.g>
In-Reply-To
<53cffc06-ebb1-ac97-ceb4-4c242a82c68a@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
> it. Having just read Peff's message this does not make much difference
> to the test timings and if I'd seen that before I wouldn't have posted
> this.

Ah, I forgot about that conclusion, i.e. while this does look the right thing to do, it didn't make much difference in practice.

It still is tempting to take it, though :-), if only to stop people sending in the same patch in the future without benchmarking, as long as it does not make it worse.

Thanks.
Previous: Phillip WoodNext: Junio C Hamano
Message 5 of 6 in “tests: cache glibc version check”
  1. tests: cache glibc version checkPhillip Wood via GitGitGadget, Aug 4, 2022
  2. Phillip WoodAug 4, 2022
  3. Junio C HamanoAug 4, 2022
  4. Phillip WoodAug 4, 2022
  5. Junio C HamanoAug 4, 2022
  6. Junio C HamanoAug 4, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.