Re: [PATCH v3 3/3] send-email: add option to generate passswords like OAuth2 tokens

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 22, 2025, 22:20 UTC
Message-ID: <xmqqh62f3kji.fsf@gitster.g>
In-Reply-To: <PN3PR01MB9597813722A475923ED1C036B8BB2@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>

Aditya Garg <gargaditya08@live.com> writes:

Show 7 quoted lines

> +--smtp-passeval[=<command>]::
> +	Generate password or OAuth2 token for SMTP AUTH. The argument is
> +	optional. If specified, it will use the output of any password
> +	or OAuth2 token generated using the command specified.
> ++
> +Note that it will override any existing password specified using
> +`--smtp-user` or a `sendemail.smtpUser`.

If the argument is optional, we should explain what the behaviour is when the optional argument is omitted, as well as how the given argument is used. You are doing only the latter, but not the former.

Shouldn't the "command" be mandatory, if the option is used? I do not quite see how these invocations

	git-send-email ... --smtp-passeval ...
	git-send-email ... --smtp-passeval= ...

that do not specify the command to be used is useful.