Re: [PATCH] ci: skip unavailable external software

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2025, 09:49 UTC
Message-ID: <xmqqh62cwoya.fsf@gitster.g>
In-Reply-To: <aAsNUYUKJZbrMCf2@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> I think it would be preferable to only handle failure of wget as chmod
> shouldn't ever fail if wget was successful. The same is true for the
> other downloads -- let's be as strict as possible but allow failure of
> those actions that depend on the network.

You may think so (as I thought so too before hitting a snag or two) ;-).

The thing is, failing "wget --output-document" leaves an empty file, and an empty file does not still cause "if type jgit; then" to take the "else" clause, and the invocation of "jgit version" would fail, taking the whole thing out, due to the "set -e" thing.