Re: [PATCH v2] meson: allow customize perl installation path

From: Junio C Hamano <gitster@pobox.com>
Date: May 8, 2025, 14:34 UTC
Message-ID: <xmqqh61v893e.fsf@gitster.g>
In-Reply-To: <a9d431944b6d94e0eb25535c061fc226a7fefa9e.1746692662.git.congdanhqx@gmail.com>

Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:

Show 8 quoted lines

> Some distros, notably Fedora, want to install non-core Perl libraries
> into specific directory, namely /usr/share/perl5/vendor_perl.
>
> The Makefile build system allows this by overriding perllibdir variable,
> let's make meson works on par with our Makefile.
>
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> ---

Will queue. The incremental since the previous iteration looks exactly as Patrick suggested, which looks good to me, too.

Thanks.

Show 13 quoted lines

> Range-diff against v1:
> 1:  14e38695adbd6 ! 1:  a9d431944b6d9 meson: allow customize perl installation path
>     @@ meson.build: if perl_features_enabled
>       ## meson_options.txt ##
>      @@
>      +# Configuration for Git installation
>     -+
>      +option('perllibdir', type: 'string', value: '',
>     -+  description: 'Directory to install perl lib to. Default to <datadir>/perl5')
>     ++  description: 'Directory to install perl lib to. Defaults to <datadir>/perl5')
>      +
>       # Configuration for how Git behaves at runtime.
>       option('default_pager', type: 'string', value: 'less',