Re: [PATCH v2 0/2] packfile: avoid access(3p) calls for missing packs

From: Junio C Hamano <gitster@pobox.com>
Date: May 21, 2025, 13:24 UTC
Message-ID: <xmqqh61edrlq.fsf@gitster.g>
In-Reply-To: <20250520-pks-pack-avoid-stats-on-missing-v2-0-333c5217fb05@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Changes in v2:
>   - Drop the patch that reorders syscalls and add a comment explaining
>     why the order is important.

Much nicer.

>   - Add a negative lookup cache for indexed packfiles.

Looking very good.

Thanks, queued.

Show 24 quoted lines

>   - Link to v1: https://lore.kernel.org/r/20250516-pks-pack-avoid-stats-on-missing-v1-1-e2ef4d8798a3@pks.im
>
> Thanks!
>
> Patrick
>
> ---
> Patrick Steinhardt (2):
>       packfile: explain ordering of how we look up auxiliary pack files
>       midx: stop repeatedly looking up nonexistent packfiles
>
>  midx.c     | 10 ++++++++--
>  packfile.c | 11 +++++++++++
>  2 files changed, 19 insertions(+), 2 deletions(-)
>
> Range-diff versus v1:
>
> 1:  31ffb3712ca < -:  ----------- packfile: avoid access(3p) calls for missing packs
> -:  ----------- > 1:  6125b84389d packfile: explain ordering of how we look up auxiliary pack files
> -:  ----------- > 2:  8cb82a771c0 midx: stop repeatedly looking up nonexistent packfiles
>
> ---
> base-commit: 1a8a4971cc6c179c4dd711f4a7f5d7178f4b3ab7
> change-id: 20250516-pks-pack-avoid-stats-on-missing-8e3b75755cf0