git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] cat-file: fix mailmap application for different author and committer

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 13, 2025, 15:56 UTC
Message-ID
<xmqqh60jab3o.fsf@gitster.g>
In-Reply-To
<CAP8UFD37rFvhO_XLhSjZNoOQ_ePwrrALYBcqKHfhMKcpqhkP8Q@mail.gmail.com>
Christian Couder <christian.couder@gmail.com> writes:
Show 14 quoted lines
> On Fri, Jun 13, 2025 at 1:58 PM <siddharthasthana31@gmail.com> wrote:
>
> [...]
>
>> This bug was introduced in e9c1b0e3 (revision: improve
>> commit_rewrite_person(), 2022-07-19) when the much simpler version of
>> commit_rewrite_person() that worked on one "person header" at a time
>> was rewritten to use the current apply_mailmap_to_header() function.
>> The original implementation processed author and committer separately,
>> but the rewrite introduced this loop-based approach that failed to
>> properly handle the transition between identity lines.
>
> Thanks for adding this context and improving the `sed` invocation in
> the tests! Happy to stand behind this change too :-)

Thanks, all. Queued. Let's mark it for 'next', hoping that the fix will be in the first batch in the post 2.50 cycle.

Previous: Christian Couder
Message 10 of 10 in “cat-file: fix mailmap application for different author and committer”
  1. cat-file: fix mailmap application for different author and committersiddharthasthana31@gmail.com, Jun 11, 2025
  2. Christian CouderJun 11, 2025
  3. Junio C HamanoJun 12, 2025
  4. Junio C HamanoJun 11, 2025
  5. Eric SunshineJun 11, 2025
  6. Junio C HamanoJun 11, 2025
  7. Siddharth AsthanaJun 13, 2025
  8. cat-file: fix mailmap application for different author and committersiddharthasthana31@gmail.com, Jun 13, 2025
  9. Christian CouderJun 13, 2025
  10. Junio C HamanoJun 13, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.