Re: [RFC Outreachy] Teach ci/check-whitespace to flag incomplete lines as an error
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 13, 2025, 15:41 UTC
- Message-ID
- <xmqqh5w23j3k.fsf@gitster.g>
- In-Reply-To
- <CAD=f0L-QAfMhBw1_RyLkpdntjPfu4M+temmawWGEZjAJn_iQdQ@mail.gmail.com>
Bello Olamide <belkid98@gmail.com> writes:
Show 9 quoted lines
>> we want. We need a mechanism that notices and warns when a commit >> makes a file, which used to end with a newline, end in an incomplete >> line. > > Thank you for the clarity. This would mean to compare the relevant files in the > current commit with its parent commit and report when the current commit removes > the new line at the end of file which was present in the parent commit. > > But how about when a file is newly added and lacks the new line?
Yes, you should notice and flag any new incomplete line that did not exist before that are added by the commit.