Re: [PATCH 00/18] odb: make loose object source a proper `struct odb_source`
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 1, 2026, 21:33 UTC
- Message-ID
- <xmqqh5nm3q09.fsf@gitster.g>
- In-Reply-To
- <20260521-b4-pks-odb-source-loose-v1-0-6553b399be2d@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 15 quoted lines
> Hi, > > this patch series converts the loose object source into a proper `struct > odb_source` so that it can be used via our generic interfaces. > > The patch series is relatively straight-forward, as the source basically > already exists as such and the interfaces already match. So for most of > the part we are just moving around some code and converting functions > that were previously called directly into callbacks. > > I guess the only part that needs some attention is that there is some > confusion at first with the `struct odb_source_loose::source` parent > pointer that initially points at the owning `struct odb_source_files`. > This relationship doesn't make much sense, as a loose source can totally > exist standalone without the files source.
No significant comments came in the past week or so on these patches. Should we declare victory, and mark it for 'next'? I can locally amend a typo in [3/18] (<xmqqh5o0zrsr.fsf@gitster.g>).