Re: [PATCH v4 0/8] Auto-configure advertised remotes via URL allowlist
Toon Claes <toon@iotcl.com> writes:
Show 14 quoted lines
>> Also I think it's easier to explain that 'acceptFromServerUrl' is a
>> different mechanism (that allows auto-configuration, contrary to
>> 'acceptFromServer') if these two variables are independent.
>
> True, although naming-wise it doesn't feel like that. But I no longer
> gonna keep picking on that, so ignore this comment please. :-)
>
>>> What do you think? If you disagree, I'm fine with the current approach
>>> and I think this version looks good.
>>
>> Thanks for your review and for being fine with the current approach if
>> I disagree.
>
> Thanks for explaining, I still agree moving on like this.
Sounds good. Shall we mark the topic for 'next' then?
Thanks, all.