git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Performance regression in connectivity check during receive-pack (git 2.54)

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 22, 2026, 15:49 UTC
Message-ID
<xmqqh5lrrplt.fsf@gitster.g>
In-Reply-To
<amCuLpT6vYzo1GF8@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 11 quoted lines
> The alternative to this would be to instead have logic in functions like
> `odb_write()` that checks whether we have an active transaction or not.
> If so, the write would go into the transaction directly instead of going
> into the primary source, and consequently we wouldn't even have to
> modify the list of sources at all.
>
> This shouldn't create too much of a problem, as we typically don't
> intend to even read objects that we've written into the transaction
> immediately. It would avoid that we try to read objects from the
> temporary object directory. And it would also allow us to eventually
> move all the logic to write objects into the transactions exclusively.

I suspect several of those 'transactions' are actually misspelt 'temporary directories', but I catch your drift. That said, a redesign like that feels more or less independent of the fix for our immediate performance regression.

After all, didn't Peff show us a case where no odb sources were being flipped in the middle? Simply setting up one object store to borrow from another via the alternates mechanism demonstrated that checking packs across all object stores before hunting for loose objects in any of them makes a world of difference.

> I'm currently out of office though, and will be on vacation next week.
> I'll explore this area a bit more though once I'm back in office in two
> weeks.
Understood.  Bon voyage and have fun!
Previous: Patrick SteinhardtNext: Jeff King
Message 6 of 13 in “Performance regression in connectivity check during receive-pack (git 2.54)”
  1. Wolfgang KritzingerJul 21, 2026
  2. Jeff KingJul 21, 2026
  3. Taylor BlauJul 21, 2026
  4. Junio C HamanoJul 21, 2026
  5. Patrick SteinhardtJul 22, 2026
  6. Junio C HamanoJul 22, 2026
  7. Jeff KingJul 23, 2026
  8. Patrick SteinhardtJul 24, 2026
  9. Jeff KingJul 26, 2026
  10. Justin ToblerJul 27, 2026
  11. Patrick SteinhardtAug 4, 2026
  12. Jeff KingJul 23, 2026
  13. Jeff KingJul 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.