git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[micro] Use 'env' on test_must_fail as appropriate

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 7, 2014, 01:14 UTC
Message-ID
<xmqqfvmuvmh4.fsf@gitster.dls.corp.google.com>
In-Reply-To
<xmqq1tyex6by.fsf@gitster.dls.corp.google.com>

Because "VAR=VAL command" is sufficient to run 'command' with environment variable VAR set to value VAL without affecting the environment of the shell itself, but we cannot do the same with a shell function (most notably, "test_must_fail"), we have subshell invocations with multiple lines like this:

	... &&
	(
        	VAR=VAL &&
                export VAR &&
                test_must_fail git command
	) &&
        ...
which could be expressed as
	... &&
        test_must_fail env VAR=VAL git comand &&
	...
Find and shorten such constructs in existing test scripts.

Note that I am not 100% convinced myself that it is a good idea to do this, so please do not add this to the list without seeing it discussed.

Thanks.
Previous: Junio C Hamano
Message 2 of 2 in “*.sh: drop useless use of "env"”
  1. *.sh: drop useless use of "env"Junio C Hamano, Mar 6, 2014
  2. [micro] Use 'env' on test_must_fail as appropriateJunio C Hamano, Mar 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.