git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 1/4] Documentation: Fix misuses of "nor"

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 1, 2014, 19:04 UTC
Message-ID
<xmqqfvlw27nq.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAMuNMfokH8cVwYmuPX7jY+i6Vp9nPKLS+7rZKUyMvw-8yDOGmQ@mail.gmail.com>
Justin Lebar <jlebar@google.com> writes:
[administrivia: please do not top-post]
Show 9 quoted lines
> On Mon, Mar 31, 2014 at 4:19 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Four patches queued on 'pu' as-is (but retitled).  I didn't read
>> everything very carefully, though.
>>
>> Thanks.
>
> It's unclear to me: Are we done with this patch queue, or do I need to
> worry about getting these patches into another branch?  If the latter,
> I'll update patch v5 per your comments.

I didn't read everything very carefully, so I cannot vouch for the correctness of all the rewrites myself, hence I will not be merging it to 'next' or closer-to-release branches with confidence, at least not yet. Once I hear from somebody else who proof-read the changes (or if I find the time to do so myself), I may be able to do so. Or somebody else (or myself) may find problems with the change and send further review comments to the list, in which case you would want to incorporate them in a reroll, ande the process continues on that new version.

I do not remember there were other comments on the latest version of the series---I suspect not many people had chance to read them yet, so we may have to wait for "further review comments" for a few days at least.

Thanks.
Previous: Justin Lebar
Message 8 of 8 in “Documentation: Fix misuses of "nor"”
  1. 1/4 Documentation: Fix misuses of "nor"Justin Lebar, Mar 31, 2014
  2. 2/4 contrib: Fix misuses of "nor"Justin Lebar, Mar 31, 2014
  3. 3/4 Fix misuses of "nor" in commentsJustin Lebar, Mar 31, 2014
  4. 4/4 Fix misuses of "nor" outside comments and in testsJustin Lebar, Mar 31, 2014
  5. Junio C HamanoMar 31, 2014
  6. Junio C HamanoMar 31, 2014
  7. Justin LebarApr 1, 2014
  8. Junio C HamanoApr 1, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.