Re: [PATCH v2] Sleep 1 millisecond in poll() to avoid busy wait

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 28, 2014, 18:58 UTC
Message-ID: <xmqqfvkxqo0l.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CABPQNSbpyFzg8A8gLp2nJZeTRSLSb0Qs8ytZDsJLmi6VyER71Q@mail.gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

Show 11 quoted lines

> On Mon, Apr 28, 2014 at 5:35 PM, Stepan Kasal <kasal@ucw.cz> wrote:
>> From: theoleblond <theodore.leblond@gmail.com>
>> Date: Wed, 16 May 2012 06:52:49 -0700
>>
>> ...
>> I also tested the very fast local case, and didn't see any measurable
>> difference. On a big repo with 4500 files, the upload-pack took about 2
>> seconds with and without the fix.
>> ---
>>
> Good stuff!

Do I expect to be forwarded this patch with proper provenance sign-off chain thru you?

I do not mind adding Ack from you and J6t I saw in this thread myself, perhaps like the following:

    Subject: compat/poll: sleep 1 millisecond to avoid busy wait
    From: Theodore Leblond <theodore.leblond@gmail.com>

    SwitchToTrhead() only gives...
    ...
    seconds with and without the fix.

    Signed-off-by: Theodore Leblond <theodore.leblond@gmail.com>
    Signed-off-by: Stepan Kasal <kasal@ucw.cz>
    Acked-by: Johannes Sixt <j6t@kdbg.org>
    Acked-by: Erik Faye-Lund <kusmabite@gmail.com>

I am just having this feeling that I lack the background on the evolution of this patch to say the above properly records the provenance.

Oh, also in the last paragraph, who is "I" who tested? Theodore, or Stepan?

Thanks.