Re: [PATCH v2] Makefile: default to -lcurl when no CURL_CONFIG or CURLDIR

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 28, 2014, 21:32 UTC
Message-ID: <xmqqfvkxnnqu.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1398718883-5630-1-git-send-email-dborowitz@google.com>

Dave Borowitz <dborowitz@google.com> writes:

Show 12 quoted lines

> The original implementation of CURL_CONFIG support did not match the
> original behavior of using -lcurl when CURLDIR was not set. This broke
> implementations that were lacking curl-config but did have libcurl
> installed along system libraries, such as MSysGit. In other words, the
> assumption that curl-config is always installed was incorrect.
>
> Instead, if CURL_CONFIG is empty or returns an empty result (e.g. due
> to curl-config being missing), use the old behavior of falling back to
> -lcurl.
>
> Signed-off-by: Dave Borowitz <dborowitz@google.com>
> ---

Thanks. Will pick this version up.