Re: [PATCH] Update git-multimail to version 1.0.2

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 27, 2015, 19:05 UTC
Message-ID: <xmqqfv7lwfvx.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpq618hqu5d.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 32 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>
>>> Junio C Hamano <gitster@pobox.com> writes:
>>>
>>>> Was that obtained from the upstream project (i.e. you) and match
>>>> your 1.0.2 tag?
>>>
>>> Yes. Isn't that what the text above says?
>>
>> Well, the patch does not update git_multimail.py at all.  Requoting
>> the part you omitted from my response
>>
>>     $ git rev-list -1 master contrib/hooks/multimail/
>>     b513f71f6043c05c3918e670b332dfa7ec6b2661
>>
>>     which is b513f71f (git-multimail: update to version 1.0.0,
>>     2014-04-07)
>>
>> it matches what "was obtained from the upstream project on
>> 2014-04-07".
>
> Yes, but it also matches "was obtained on 2015-04-27", since only the
> README has changed (the commit message of this patch says: "The only
> changes are to the README files, most notably the list of maintainers
> and the project URL.").
>
>> Or did you forget to include the update to the software in the
>> patch?
>
> The update to the software is empty.

Hmm, that may be technically correct but it is grossly misleading to update the existing "was obtained on 2014-04-07" to "was obtained on 2015-04-27", especially if nothing was actually obtained, isn't it? I honestly am surprised that, after seeing the announcement about "a new repository, co-maintainer and multiple contributors", no code change is made over the past 12 months.

I would understand it if the description were "The version in this directory matches the upstream project as of 2015-04-27", though.