Re: [PATCH] push: don't mark options of recurse-submodules for translation

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 22, 2015, 22:14 UTC
Message-ID: <xmqqfuyuceqw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1450806780-16822-1-git-send-email-ralf.thielow@gmail.com>

Ralf Thielow <ralf.thielow@gmail.com> writes:

Show 18 quoted lines

> Signed-off-by: Ralf Thielow <ralf.thielow@gmail.com>
> ---
>  builtin/push.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/push.c b/builtin/push.c
> index cc29277..8963dbd 100644
> --- a/builtin/push.c
> +++ b/builtin/push.c
> @@ -547,7 +547,7 @@ int cmd_push(int argc, const char **argv, const char *prefix)
>  		  0, CAS_OPT_NAME, &cas, N_("refname>:<expect"),
>  		  N_("require old value of ref to be at this value"),
>  		  PARSE_OPT_OPTARG, parseopt_push_cas_option },
> -		{ OPTION_CALLBACK, 0, "recurse-submodules", &recurse_submodules, N_("check|on-demand|no"),
> +		{ OPTION_CALLBACK, 0, "recurse-submodules", &recurse_submodules, "check|on-demand|no",
>  			N_("control recursive pushing of submodules"),
>  			PARSE_OPT_OPTARG, option_parse_recurse_submodules },
>  		OPT_BOOL( 0 , "thin", &thin, N_("use thin pack")),

Makes sense.  I should redo the -rc2 with this patch in.

Thanks.