Re: [PATCH] git: submodule honor -c credential.* from command line

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 25, 2016, 00:43 UTC
Message-ID: <xmqqfuwhr54w.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CA+P7+xrJkOaqfOBOK7oh1w97dEJytyPN5UbH6ctK+saGUSkZiw@mail.gmail.com>

Jacob Keller <jacob.keller@gmail.com> writes:

Show 15 quoted lines

>>>> Add a git submodule--helper function which can be used to sanitize the
>>>> GIT_CONFIG_PARAMETERS value to only allow certain settings. For now,
>>>> restrict this to only credential.* settings.
>>>
>>> I guess for now that subset is fine and will be expanded over time?
>>
>> I think it is more like "we pass only what is known to be necessary
>> and safe, and right now, credential.* are the only such variables."
>>
>> As the system evolves more, theoretically we might find more, but
>> let's not phrase it as if expanding is a good thing and a longer
>> term goal.
>>
>
> I can reword the commit message to that effect.

I think what you wrote was perfectly fine.