Re: [RFC/PATCH] clone: make 'git clone -c remote.origin.fetch=<refspec>' work

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2016, 01:36 UTC
Message-ID: <xmqqfuw3rrwb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1457313062-10073-1-git-send-email-szeder@ira.uka.de>

SZEDER Gábor <szeder@ira.uka.de> writes:

Show 6 quoted lines

> Check whether there are any relevant configured fetch refspecs and
> take those into account during the initial fetch, unless running 'git
> clone --single-branch'.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
> ---

Even though I think the original description did not mean to include the fetch refspecs when it talked about configuration taking effect, I think what this change wants to do probably makes sense.

Show 5 quoted lines

>
> I'm unsure what to do with the '-c <fetch-refspec> --single-branch'
> combination: it doesn't really make sense to me and can't imagaine a
> use case where it would be useful...  but perhaps I just lack
> imagination on this Sunday night.  Hence the RFC.

My knee-jerk reaction is to change the last paragraph of your log message to read more like

	Always read the fetch refspecs from the newly created config
	file, and use that for the initial fetching.

and do so even when running with "--single-branch".