git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs: mark the file-local vtable symbols as static

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 8, 2016, 18:55 UTC
Message-ID
<xmqqfusnldc4.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<57583022.2030205@ramsayjones.plus.com>
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
Show 11 quoted lines
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Michael, Junio,
>
> I would normally ask you to squash this into the relevant patch when
> you next re-roll your 'mh/ref-iterators' branch, but this has already
> been merged into next. (I normally have a bit more time ... sorry!).
>
> Perhaps, after the release, when the next branch is re-wound/re-built,
> this could be squashed into your branch then.
Yup, sounds like a plan.
Show 12 quoted lines
>
> Anyway, after applying this patch, the following symbols are still
> 'public but unused':
>
> 	> refs/files-backend.o	- files_reflog_iterator_begin
> 	> refs/iterator.o	- is_empty_ref_iterator
> 	> refs/iterator.o	- merge_ref_iterator_begin
>
> These all look (potentially) useful for the implementation of
> additional 'ref-iter' types and look to be part of the _internal_
> iterator API - so they should not be marked static. Can you just
> confirm my interpretation.
I am not Michael, but FWIW I think that is sensible.
Previous: Ramsay JonesNext: Michael Haggerty
Message 2 of 3 in “refs: mark the file-local vtable symbols as static”
  1. refs: mark the file-local vtable symbols as staticRamsay Jones, Jun 8, 2016
  2. Junio C HamanoJun 8, 2016
  3. Michael HaggertyJun 9, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.