Re: [PATCH] contrib/persistent-https: update ldflags syntax for Go 1.7+

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 18, 2016, 20:36 UTC
Message-ID: <xmqqfur6isyr.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160716051800.GA2845@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

>> This `name=value` syntax for the -X flag was introduced in Go v1.5
>> (released Aug 19, 2015):
>> 
>> - release notes: https://golang.org/doc/go1.5#link
>> - commit: https://github.com/golang/go/commit/12795c02f3d6fc54ece09a86e70aaa40a94d5131
>> 
>> In Go v1.7, support for the old syntax was removed:
>> 
>> - release notes: https://tip.golang.org/doc/go1.7#compiler
>> - commit: https://github.com/golang/go/commit/51b624e6a29b135ce0fadb22b678acf4998ff16f
>> 
>> This patch includes the `=` to fix builds with Go v1.7+.
>
> With the disclaimer that I have very little experience with Go, this
> seems like a good, well-explained change. My only question would be
> whether people still use pre-v1.5 versions of Go, since it sounds like
> this would adversely affect them if they do. (If it does, it seems the

Yeah, you get something like this:

    $ ./git-remote-persistent-https --print_label
    2016/07/18 13:34:33 unlabeled build; build with "make" to label

which is probably not the end of the world. The label does not even identify the version of the source in any way, so I am not sure how people are depending on that feature anyway ;-)