Re: What's cooking in git.git (Aug 2016, #02; Thu, 4)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 4, 2016, 23:32 UTC
- Message-ID
- <xmqqfuqkyutp.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160804225649.q77p4u6cbdo6q336@glandium.org>
Mike Hommey <mh@glandium.org> writes:
Show 13 quoted lines
> On Thu, Aug 04, 2016 at 03:28:55PM -0700, Junio C Hamano wrote: >> * mh/connect (2016-06-06) 10 commits >> - connect: [host:port] is legacy for ssh >> ... >> - connect: document why we sometimes call get_port after get_host_and_port >> >> Rewrite Git-URL parsing routine (hopefully) without changing any >> behaviour. >> >> It has been two months without any support. We may want to discard >> this. > > What kind of support are you expecting?
The only rationale I recall you justifying this series was that this makes the resulting code easier to read, but I do not recall other people agreeing with you, and I do not particularly see the resulting code easier to follow.
> FWIW, I have WIP cleaning up the code further, tha obviously depends on > this series.
As this is not even in 'next', your cleaning-up does not have to depend on it. It can be part of a reroll, of course.
By the way, "discarding" is not equal to "rejecting". The latter is "it is a bad thing to do, don't even come back with a new version". It is just "This hasn't made any progress, and it is not ready for 'next', either. Keeping it in 'pu' is eating my time without giving much benefit to the project at this point".