Re: [PATCH v10 8/9] submodule: refactor show_submodule_summary with helper function
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 23, 2016, 23:07 UTC
- Message-ID
- <xmqqfupvt776.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160822234344.22797-9-jacob.e.keller@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
Show 18 quoted lines
> From: Jacob Keller <jacob.keller@gmail.com> > > A future patch is going to add a new submodule diff format which > displays an inline diff of the submodule changes. To make this easier, > and to ensure that both submodule diff formats use the same initial > header, factor out show_submodule_header() function which will print the > current submodule header line, and then leave the show_submodule_summary > function to lookup and print the submodule log format. > > This does create one format change in that "(revision walker failed)" > will now be displayed on its own line rather than as part of the message > because we no longer perform this step directly in the header display > flow. However, this is a rare case as most causes of the failure will be > due to a missing commit which we already check for and avoid previously. > flow. However, this is a rare case and shouldn't impact much. > > Signed-off-by: Jacob Keller <jacob.keller@gmail.com> > ---
Up to this step it all looked sensible. I'll take a look at 9/9 later.
Thanks.